hemantk-12 commented on code in PR #5177:
URL: https://github.com/apache/ozone/pull/5177#discussion_r1297634056
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java:
##########
@@ -894,9 +894,9 @@ void generateSnapshotDiffReport(final String jobKey,
new RocksDbPersistentMap<>(db, toSnapshotColumnFamily, codecRegistry,
byte[].class, byte[].class);
// Set of unique objectId between fromSnapshot and toSnapshot.
- final PersistentMap<byte[], SnapshotDiffObject> objectIdToDiffObject =
+ final PersistentMap<byte[], byte[]> objectIdToDiffObject =
Review Comment:
Thanks for the change. I'm surprised the `BooleanCodec` was not there.
Curious if there was any specific reason to not have it because we have codecs
for other primitives.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
