[
https://issues.apache.org/jira/browse/HDDS-8665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755691#comment-17755691
]
Hemant Kumar edited comment on HDDS-8665 at 8/17/23 8:47 PM:
-------------------------------------------------------------
Hi [~ritesh]
I removed the newbie label. It has much more complication than just
implementing CopyObject.
We need to change the logic of SnapshotChain update. Currently we update it
[here|https://github.com/apache/ozone/blob/master/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/response/snapshot/OMSnapshotPurgeResponse.java#L149-L176]
but it doesn't update the cache. Which is causing assertion failure in test:
TestOMSnapshotPurgeRequestAndResponse.testSnapshotChainCleanup.
was (Author: JIRAUSER297350):
Hi [~ritesh]
I removed the newbie label. It has much more complication than just
implementing CopyObject.
We need to change the logic of SnapshotChain update. Currently we update it
[here|https://github.com/apache/ozone/blob/master/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/response/snapshot/OMSnapshotPurgeResponse.java#L149-L176]
but it doesn't update the cache. Which is causing assertion failure in test.
> OmDBSnapshotInfoCodec.copyObject(..) does not follow the general contract of
> copy.
> ----------------------------------------------------------------------------------
>
> Key: HDDS-8665
> URL: https://issues.apache.org/jira/browse/HDDS-8665
> Project: Apache Ozone
> Issue Type: Sub-task
> Components: OM, Snapshot
> Reporter: Tsz-wo Sze
> Assignee: Hemant Kumar
> Priority: Critical
> Attachments: HDDS-8665_bug.patch
>
>
> OmDBSnapshotInfoCodec.copyObject(..) is a shallow copy -- it simply returns
> the same object. However, if it is changed to return a deep copy as shown in
> the second comment, TestOMSnapshotDeleteRequest and
> TestOMSnapshotPurgeRequestAndResponse will fail. These two tests depend on
> the behavior that, after copying, changing one copy will also change the
> other copy.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
