ashishkumar50 commented on PR #5199: URL: https://github.com/apache/ozone/pull/5199#issuecomment-1685611470
> @ashishkumar50 is this change necessary? The iteration is only checking one key, and volume delete is an uncommon operation. I don't think we will see any noticeable performance change. However, this could cause correctness issues if the bucket table is switched to partial cache in the future. I don't think that would happen, but I would rather not have that assumption hiding in the code. Change is not necessary, made this change because of comment given in [PR](https://github.com/apache/ozone/pull/5051#issuecomment-1633850262). And yes this is a very rare operation and iterating a single key doesn't give much benefit. Only point is since bucket table is FULL cache but still we are not utilizing it. Shall I abandon this PR @errose28 @sumitagrawl ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
