devabhishekpal commented on code in PR #5176:
URL: https://github.com/apache/ozone/pull/5176#discussion_r1299887887
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/components/overviewCard/overviewCard.tsx:
##########
@@ -46,18 +46,31 @@ const defaultProps = {
interface IOverviewCardWrapperProps {
linkToUrl: string;
+ title:string
}
class OverviewCardWrapper extends React.Component<IOverviewCardWrapperProps> {
render() {
const {linkToUrl, children} = this.props;
- if (linkToUrl) {
+ if (linkToUrl ) {
+ if(linkToUrl === '/Om'){
Review Comment:
Can we shorten this check? Instead of spanning two lines can you try to make
the check as:
```
if (linkToUrl){
return (
<Link to={{
pathname: linkToUrl
state: { linkToUrl === "/Om" ? { activeTab: .... } : undefined }
}}
/>
)
}
```
Could you check this out?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
