sodonnel commented on PR #5191: URL: https://github.com/apache/ozone/pull/5191#issuecomment-1686136608
> The javadoc suggests that we also need to catch `PipelineNotFoundException` in `PipelineManagerImpl#removeContainerFromPipeline` when getting a pipeline: > > ``` > Pipeline pipeline = stateManager.getPipeline(pipelineID); > ``` I think you are correct. It would be safer to catch the PNF exception from the getPipeline call too. I have updated it. I didn't even notice the replicate annotation, as it was annotating the interface rather than the implementation, and I did not check the interface! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
