kaijchen commented on PR #5072: URL: https://github.com/apache/ozone/pull/5072#issuecomment-1686745339
> Regarding the `OMRequestTestUtils`, I extended some existing functions instead of adding new methods for better reuse since I found it confusing by the amount of similar methods in the util class. I ensured that the API does not change for the existing (non-related) tests by providing proper default value. Also there doesn't seem to be conflicts with `OMRequestTestUtils` when I merged with master. SGTM, thanks for the improvement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
