hemantk-12 commented on code in PR #5165:
URL: https://github.com/apache/ozone/pull/5165#discussion_r1300702268
##########
hadoop-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdb/util/ManagedSstFileReader.java:
##########
@@ -89,16 +90,31 @@ public long getEstimatedTotalKeys() throws RocksDBException
{
}
public Stream<String> getKeyStream() throws RocksDBException {
+ return getKeyStream(Optional.empty(), Optional.empty());
+ }
+
+ public Stream<String> getKeyStream(Optional<String> lowerBound,
+ Optional<String> upperBound) throws RocksDBException {
// TODO: [SNAPSHOT] Check if default Options and ReadOptions is enough.
final MultipleSstFileIterator<String> itr =
new MultipleSstFileIterator<String>(sstFiles) {
private ManagedOptions options;
private ReadOptions readOptions;
+ private Optional<ManagedSlice> lowerBoundSLice;
+
+ private Optional<ManagedSlice> upperBoundSlice;
Review Comment:
Then close is missing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
