ChenSammi commented on code in PR #4523: URL: https://github.com/apache/ozone/pull/4523#discussion_r1301739685
########## hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3secret/S3SecretGenerateEndpoint.java: ########## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with this + * work for additional information regarding copyright ownership. The ASF + * licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * <p> + * http://www.apache.org/licenses/LICENSE-2.0 + * <p> + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations under + * the License. + * + */ + +package org.apache.hadoop.ozone.s3secret; + +import org.apache.hadoop.ozone.audit.S3GAction; +import org.apache.hadoop.ozone.om.helpers.S3SecretValue; + +import javax.ws.rs.GET; +import javax.ws.rs.Path; +import javax.ws.rs.core.Response; +import java.io.IOException; + +/** + * Endpoint to generate and return S3 secret. + */ +@Path("/secret/generate") +@S3SecretEnabled +public class S3SecretGenerateEndpoint extends S3SecretEndpointBase { + @GET + public Response get() throws IOException { + S3SecretResponse s3SecretResponse = new S3SecretResponse(); + S3SecretValue s3SecretValue = generateS3Secret(); Review Comment: There is one change in generateS3Secret #4538, which will only return the secret the first time when a user principal is used. So this generateS3Secret will not always success after #4538 is merged. Failure case need to be considered here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
