ChenSammi commented on code in PR #5203:
URL: https://github.com/apache/ozone/pull/5203#discussion_r1302745596


##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMBlockProtocolServer.java:
##########
@@ -333,6 +338,7 @@ public boolean addSCM(AddSCMRequest request) throws 
IOException {
   @Override
   public List<DatanodeDetails> sortDatanodes(List<String> nodes,
       String clientMachine) throws IOException {
+    scm.checkAdminAccess(getRemoteUser(), false);

Review Comment:
   sortDatanodes is kind of a read operation, it doesn't change the in memory 
or persist state of pipeline.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to