GeorgeJahad opened a new pull request, #5215: URL: https://github.com/apache/ozone/pull/5215
## What changes were proposed in this pull request? ### Incorrect hard links The tarball creation code was incorrectly assuming that two sst files with the same name, (but different directories,) were hard linked to each other. See the jira ticket for an example of how this can happen. To remedy this, the tarball creation process must check the INodes of each file to confirm they are equal before linking them together. That is the purpose of this PR. ### Incomplete exclude list The exclude list is a list of sst files the follower generates and sends to the leader when requesting a tarball. It includes all the sst files already received by the follower so that the leader doesn't need to resend them. The leader also uses this list to decide what hard links to create. Prior to adding the inode check described above, the filename was all that was required for this hard link determination. Now that we need to check INodes, the excludeList needs to be modified to keep track of both the src and dest directories of the sst files. (The src dir is where it is on the host, the dest is where it is on the client.) Most of the changes in this PR deal with that data structure change. ## What is the link to the Apache JIRA https://issues.apache.org/jira/browse/HDDS-9207 ## How was this patch tested? Updated unit tests and tested on a real cluster with 10 million keys and 1000 snapshots. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
