Tejaskriya commented on code in PR #5200:
URL: https://github.com/apache/ozone/pull/5200#discussion_r1304624211
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneConsts.java:
##########
@@ -427,12 +427,12 @@ private OzoneConsts() {
* contains illegal characters when creating/renaming key.
*
* Avoid the following characters in a key name:
- * "\", "{", "}", "^", "<", ">", "#", "|", "%", "`", "[", "]", "~", "?"
+ * "\", "{", "}", "<", ">", "^", "?", "%", "~", "#", "|", "`", "[", "]"
* and Non-printable ASCII characters (128–255 decimal characters).
- * https://docs.aws.amazon.com/AmazonS3/latest/dev/UsingMetadata.html
+ * https://docs.aws.amazon.com/AmazonS3/latest/userguide/object-keys.html
*/
public static final Pattern KEYNAME_ILLEGAL_CHARACTER_CHECK_REGEX =
- Pattern.compile("^[^^{}<>^?%~#`\\[\\]\\|\\\\(\\x80-\\xff)]+$");
+ Pattern.compile("^[^\\\\{}<>^?%~#|`\\[\\]\\x80-\\xff]+$");
Review Comment:
Thank you for the review! I have made the changes now and added the cases in
the test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
