sadanand48 commented on code in PR #5222:
URL: https://github.com/apache/ozone/pull/5222#discussion_r1305344999
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java:
##########
@@ -1429,6 +1430,16 @@ private void initializeRatisDirs(OzoneConfiguration
conf) throws IOException {
}
OmUtils.createOMDir(omRatisDirectory);
+ String omStorageDir = conf.get(OMConfigKeys.OZONE_OM_RATIS_STORAGE_DIR);
+ String scmStorageDir =
+ conf.get(ScmConfigKeys.OZONE_SCM_HA_RATIS_STORAGE_DIR);
+ if (omStorageDir.equals(scmStorageDir)) {
Review Comment:
Please add a null check as if they are unset they would be null and by
default they are different paths so there shouldn't be an issue.
```suggestion
if (!Strings.isNullOrEmpty(omStorageDir) &&
!Strings.isNullOrEmpty(scmStorageDir) && omStorageDir.equals(scmStorageDir)) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
