hemantk-12 commented on code in PR #5223:
URL: https://github.com/apache/ozone/pull/5223#discussion_r1306009887
##########
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/TestSnapshotChain.java:
##########
@@ -65,14 +76,15 @@ public void setup() throws Exception {
private SnapshotInfo createSnapshotInfo(UUID snapshotID,
UUID pathPrevID,
- UUID globalPrevID) {
+ UUID globalPrevID,
+ long creationTime) {
return new SnapshotInfo.Builder()
.setSnapshotId(snapshotID)
.setName("test")
.setVolumeName("vol1")
.setBucketName("bucket1")
.setSnapshotStatus(SnapshotInfo.SnapshotStatus.SNAPSHOT_ACTIVE)
- .setCreationTime(Time.now())
+ .setCreationTime(creationTime)
Review Comment:
I doubt it is correct to say "this is a negative testcase" because it is in
decreasing order now. May be use random number if you really want it to be a
true negative test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
