errose28 commented on PR #5207: URL: https://github.com/apache/ozone/pull/5207#issuecomment-1693816939
Thanks for working on this @sumitagrawl. I did not get a chance to thoroughly review the changes, but checking the size of the proto is a good idea. Looks like there should not be any performance issues with `getSerializedSize()` according to this old [mail thread](https://groups.google.com/g/protobuf/c/BwzA9jIigZU?pli=1) I dug up. Would it make sense to increase the Ratis buffer limit in the PR as well? After RATIS-1783 that change should be effective. cc @kerneltime @szetszwo who also looked at this issue in the past. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
