sadanand48 commented on code in PR #5217:
URL: https://github.com/apache/ozone/pull/5217#discussion_r1307144675


##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestOzoneFileSystem.java:
##########
@@ -1618,15 +1621,13 @@ public void testGetTrashRoots() throws IOException {
    * since fs.rename(src,dst,options) is enabled.
    */
   @Test
-  @Flaky("HDDS-6646")
   public void testRenameToTrashEnabled() throws Exception {

Review Comment:
   This particular test never calls deleteRootDir(), not sure how fixing 
deletRootDir makes  this test non-flaky, Anyway I feel this functionality is 
tested in testTrash method in the same class in much detail . This test was 
written before the trash feature was complete, I feel we can remove this test 
from the class.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to