errose28 commented on code in PR #5189:
URL: https://github.com/apache/ozone/pull/5189#discussion_r1307959592
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/WritableRatisContainerProvider.java:
##########
@@ -167,11 +173,14 @@ public ContainerInfo getContainer(final long size,
}
// we have tried all strategies we know and but somehow we are not able
- // to get a container for this block. Log that info and return a null.
+ // to get a container for this block. Log that info and return a null and
+ // throw an exception.
Review Comment:
Suggested change:
```
// we have tried all strategies we know but somehow we are not able
// to get a container for this block. Log that info and throw an
exception.
```
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/WritableRatisContainerProvider.java:
##########
@@ -136,11 +137,16 @@ public ContainerInfo getContainer(final long size,
} catch (IOException e) {
LOG.warn("Waiting for one of pipelines {} to be OPEN failed. ",
allocatedPipelineIDs, e);
+ failureReason = "Waiting for one of pipelines to be OPEN failed.
"
+ + e.getMessage();
Review Comment:
Should we include the allocated pipeline IDs in this message too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
