devmadhuu commented on code in PR #5217:
URL: https://github.com/apache/ozone/pull/5217#discussion_r1309158311
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestOzoneFileSystem.java:
##########
@@ -1657,15 +1663,21 @@ public void testTrash() throws Exception {
isAssignableFrom(TrashPolicyOzone.class));
assertEquals(TRASH_INTERVAL, trash.getConf().
getFloat(OMConfigKeys.OZONE_FS_TRASH_INTERVAL_KEY, 0), 0);
- // Call moveToTrash. We can't call protected fs.rename() directly
- trash.moveToTrash(path);
// Construct paths
String username = UserGroupInformation.getCurrentUser().getShortUserName();
Path userTrash = new Path(TRASH_ROOT, username);
Path userTrashCurrent = new Path(userTrash, "Current");
Path trashPath = new Path(userTrashCurrent, testKeyName);
+ // Call moveToTrash. We can't call protected fs.rename() directly
+ trash.moveToTrash(path);
+ // Added this assertion here and will be tested as part of testTrash
Review Comment:
> I'm not following this comment. What do you mean by `will be tested as
part of testTrash`? This is `testTrash` test. Is there another `testTrash`?
What am I missing?
As I mentioned, it will be handled as part of 6545 JIRA, and @sadanand48
will be working on it. Had a discussion on reason of flakiness and need to
handle separately in testTrash
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
