devabhishekpal commented on code in PR #5213:
URL: https://github.com/apache/ozone/pull/5213#discussion_r1310961916
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/utils/columnSearch.tsx:
##########
@@ -69,8 +69,16 @@ class ColumnSearch extends React.PureComponent {
filterIcon: (filtered: boolean) => (
<Icon type='search' style={{color: filtered ? '#1890ff' : undefined}}/>
),
- onFilter: (value: string, record: any) =>
- record[dataIndex].toString().toLowerCase().includes(value.toLowerCase()),
+ onFilter: (value: string, record: any) => {
+ if (record[dataIndex] !== undefined || record[dataIndex] !== null) {
+ return typeof (record[dataIndex]) === typeof {}
+ ? record[dataIndex].find(item =>
Object.values(item).toString().toLowerCase().includes(value.toLowerCase())) ?
true :false
Review Comment:
find() in JS will return the first matched element else undefined.
What this statement might be doing is if find() returns a match then true,
else if undefined, then false.
But can we write this a but more cleaner @smitajoshi12 ?
Something like `Boolean(record[dataIndex].find(.....))`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
