tanvipenumudy commented on code in PR #4885:
URL: https://github.com/apache/ozone/pull/4885#discussion_r1316386887
##########
hadoop-ozone/common/src/test/java/org/apache/hadoop/ozone/om/lock/TestKeyPathLock.java:
##########
@@ -136,8 +136,7 @@ private void testSameKeyPathWriteLockMultiThreadingUtil(
// Now all threads have been instantiated.
Assert.assertEquals(0, countDownLatch.getCount());
- lock.acquireWriteHashedLock(resource,
- generateResourceHashCode(resource, sampleResourceName));
+ lock.acquireWriteLock(resource, sampleResourceName);
Review Comment:
Nit: Similar comment change under
`TestKeyPathLock#testSameKeyPathWriteLockMultiThreadingUtil`:
https://github.com/apache/ozone/blob/1f57ff6ea7af532fdfe5fc8b1a11a5c53f744e43/hadoop-ozone/common/src/test/java/org/apache/hadoop/ozone/om/lock/TestKeyPathLock.java#L124-L125
##########
hadoop-ozone/common/src/test/java/org/apache/hadoop/ozone/om/lock/TestKeyPathLock.java:
##########
@@ -218,26 +215,15 @@ private void testDiffKeyPathWriteLockMultiThreadingUtil(
OzoneManagerLock lock, CountDownLatch countDown,
String[] sampleResourceName) {
- lock.acquireWriteHashedLock(resource,
- generateResourceHashCode(resource, sampleResourceName));
+ lock.acquireWriteLock(resource, sampleResourceName);
LOG.info("Write Lock Acquired by " + Thread.currentThread().getName());
// Waiting for all the threads to be instantiated/to reach
// acquireWriteHashedLock.
Review Comment:
```suggestion
// acquireWriteLock.
```
##########
hadoop-ozone/common/src/test/java/org/apache/hadoop/ozone/om/lock/TestKeyPathLock.java:
##########
@@ -218,26 +215,15 @@ private void testDiffKeyPathWriteLockMultiThreadingUtil(
OzoneManagerLock lock, CountDownLatch countDown,
String[] sampleResourceName) {
- lock.acquireWriteHashedLock(resource,
- generateResourceHashCode(resource, sampleResourceName));
+ lock.acquireWriteLock(resource, sampleResourceName);
LOG.info("Write Lock Acquired by " + Thread.currentThread().getName());
// Waiting for all the threads to be instantiated/to reach
// acquireWriteHashedLock.
countDown.countDown();
- while (countDown.getCount() > 0) {
Review Comment:
Nit: can we add `countDown.await()` here
##########
hadoop-ozone/common/src/test/java/org/apache/hadoop/ozone/om/lock/TestKeyPathLock.java:
##########
@@ -136,8 +136,7 @@ private void testSameKeyPathWriteLockMultiThreadingUtil(
// Now all threads have been instantiated.
Assert.assertEquals(0, countDownLatch.getCount());
- lock.acquireWriteHashedLock(resource,
- generateResourceHashCode(resource, sampleResourceName));
+ lock.acquireWriteLock(resource, sampleResourceName);
Review Comment:
Nit: can we add `countDown.await()` similar to what is done under
`TestKeyPathLock#testDiffKeyPathWriteLockMultiThreadingUtil`:
https://github.com/apache/ozone/blob/1f57ff6ea7af532fdfe5fc8b1a11a5c53f744e43/hadoop-ozone/common/src/test/java/org/apache/hadoop/ozone/om/lock/TestKeyPathLock.java#L127-L134
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
