smengcl commented on code in PR #5244:
URL: https://github.com/apache/ozone/pull/5244#discussion_r1320367698
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneListStatusHelper.java:
##########
@@ -215,7 +215,11 @@ public Collection<OzoneFileStatus> listStatusFSO(OmKeyArgs
args,
HeapEntry entry = heapIterator.next();
OzoneFileStatus status = entry.getStatus(prefixKey,
scmBlockSize, volumeName, bucketName, replication);
- map.putIfAbsent(entry.key, status);
+ // Since putIfAbsent doesn't work as expected in case of null value,
+ // so had to explicitly check using containsKey
Review Comment:
Improve comment readability
```suggestion
// Caution: DO NOT use putIfAbsent. putIfAbsent undesirably
overwrites
// the value with `status` when the existing value in the map is
null.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
