Cyrill commented on code in PR #5144:
URL: https://github.com/apache/ozone/pull/5144#discussion_r1320756546
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/BucketManagerImpl.java:
##########
@@ -69,27 +67,9 @@ public OmBucketInfo getBucketInfo(String volumeName, String
bucketName)
metadataManager.getLock().acquireReadLock(BUCKET_LOCK, volumeName,
bucketName);
try {
- String bucketKey = metadataManager.getBucketKey(volumeName, bucketName);
- OmBucketInfo value = metadataManager.getBucketTable().get(bucketKey);
- if (value == null) {
- LOG.debug("bucket: {} not found in volume: {}.", bucketName,
- volumeName);
- // Check parent volume existence
- final String dbVolumeKey = metadataManager.getVolumeKey(volumeName);
- if (metadataManager.getVolumeTable().get(dbVolumeKey) == null) {
- // Parent volume doesn't exist, throw VOLUME_NOT_FOUND
- throw new OMException("Volume not found when getting bucket info",
- VOLUME_NOT_FOUND);
- } else {
- // Parent volume exists, throw BUCKET_NOT_FOUND
- throw new OMException("Bucket not found", BUCKET_NOT_FOUND);
- }
- }
-
- value = OzoneManagerUtils.resolveLinkBucketLayout(value, metadataManager,
- new HashSet<>());
-
- return value;
+ //this is a read operation, does not resolve bucket link
+ return OzoneManagerUtils.getBucketInfo(metadataManager,
+ volumeName, bucketName);
Review Comment:
Well, this method does not perform any link resolution, the resolution is
performed solely in OzoneManager class.
I updated the comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org
