[GitHub] [ozone] devmadhuu commented on a diff in pull request #5267: HDDS-6618. [perf] Require successful basic checks for long-running tests

[via GitHub]

devmadhuu commented on code in PR #5267:
URL: https://github.com/apache/ozone/pull/5267#discussion_r1321417487


##########
.github/workflows/ci.yml:
##########
@@ -191,11 +193,7 @@ jobs:
         with:
           distribution: 'temurin'
           java-version: 8
-      - name: Execute tests
-        run: hadoop-ozone/dev-support/checks/${{ matrix.check }}.sh
-      - name: Summary of failures
-        run: cat target/${{ matrix.check }}/summary.txt
-        if: ${{ !cancelled() }}

Review Comment:
   > I think you had already fixed this problem by the changes done in 
`selective_ci_checks.sh`. `unit` is no longer emitted as part of the list of 
basic checks.
   
   Yes, so we should not include below lines in basic checks...right ?
   ```
   
         - name: Execute tests
           run: hadoop-ozone/dev-support/checks/${{ matrix.check }}.sh
         - name: Summary of failures
           run: cat target/${{ matrix.check }}/summary.txt
           if: ${{ !cancelled() }}
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org