swamirishi commented on code in PR #5285:
URL: https://github.com/apache/ozone/pull/5285#discussion_r1326365347
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/replication/ContainerImporter.java:
##########
@@ -65,9 +63,7 @@ public ContainerImporter(ConfigurationSource conf,
ContainerSet containerSet,
this.controller = controller;
this.volumeSet = volumeSet;
try {
- volumeChoosingPolicy = conf.getClass(
- HDDS_DATANODE_VOLUME_CHOOSING_POLICY, RoundRobinVolumeChoosingPolicy
- .class, VolumeChoosingPolicy.class).newInstance();
+ volumeChoosingPolicy = VolumeChoosingPolicyFactory.getPolicy(conf);
Review Comment:
Why is there a need for a volumeChoosingFactory here? Can't we just add the
DEFAULT_VOLUME_CHOOSING_POLICY in a constant class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
