[ 
https://issues.apache.org/jira/browse/HDDS-9295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17766026#comment-17766026
 ] 

Tsz-wo Sze commented on HDDS-9295:
----------------------------------

In [~duongnguyen]'s test, the GC log showed

# Without CodecBuffer: 2594M->2184M(3680M) 2.319ms
# CodecBuffer with finalize(): 659M->250M(1996M) 26.459ms

CodecBuffer (250M) did use much less memory then without it (2184M). The GCs 
have cleaned up around 400M in both cases. However, the GC time is much longer.

After this change (i.e. CodecBuffer without finalize()), the GC time is reduced 
back to #1.

> Avoid overriding finalize() in CodecBuffer
> ------------------------------------------
>
>                 Key: HDDS-9295
>                 URL: https://issues.apache.org/jira/browse/HDDS-9295
>             Project: Apache Ozone
>          Issue Type: Improvement
>          Components: db
>            Reporter: Tsz-wo Sze
>            Assignee: Tsz-wo Sze
>            Priority: Major
>              Labels: pull-request-available
>
> CodecBuffer overrides the  finalize() method for leak detection.  It turns 
> out causing a much longer GC time.  (Thanks [~duongnguyen] for finding it 
> out.)
> This JIRA is to change CodecBuffer not to override finalize().  In the test, 
> we will create a subclass to override CodecBuffer for leak detection.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to