[ 
https://issues.apache.org/jira/browse/HDDS-7843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17766737#comment-17766737
 ] 

Attila Doroszlai commented on HDDS-7843:
----------------------------------------

{code}
Executing test upgrade/test.sh
  
/home/runner/work/ozone/ozone/hadoop-ozone/dist/target/ozone-1.4.0-SNAPSHOT/compose/../../../../../dev-support/ci/lib/_all_libs.sh:
 line 19: LIBRARIES_DIR: readonly variable
  ERROR: Test execution of upgrade/test.sh is FAILED!!!!
{code}

I think the problem is that {{_all_libs.sh}} does not like being sourced 
multiple times.  {{testlib.sh}} sources it, and some scripts source 
{{testlib.sh}} multiple times (for re-initializing with different variables).

This can be solved by checking whether some definition coming from 
{{_all_libs.sh}} exists already, something like:

{code}
if ! type -f start_end::group_start >& /dev/null; then
  source "${root_dir}/dev-support/ci/lib/_all_libs.sh"
fi
{code}

> Group output of check steps
> ---------------------------
>
>                 Key: HDDS-7843
>                 URL: https://issues.apache.org/jira/browse/HDDS-7843
>             Project: Apache Ozone
>          Issue Type: Sub-task
>          Components: CI
>            Reporter: Attila Doroszlai
>            Assignee: Himanshi Darvekar
>            Priority: Major
>              Labels: usability
>
> Github Actions allows [grouping 
> output|https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#grouping-log-lines]
>  of workflow steps.  We already use it in the build-info job (selective 
> checks script).  The goal of this change is to group output in the other CI 
> checks to improve usability.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to