jyotirmoy-gh commented on code in PR #5294:
URL: https://github.com/apache/ozone/pull/5294#discussion_r1329936543
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/client/OzoneQuota.java:
##########
@@ -218,12 +216,17 @@ public static OzoneQuota parseNameSpaceQuota(String
quotaInNamespace) {
throw new IllegalArgumentException(
"Quota string cannot be null or empty.");
}
- long nameSpaceQuota = Long.parseLong(quotaInNamespace);
- if (nameSpaceQuota <= 0) {
- throw new IllegalArgumentException(
- "Invalid values for namespace quota: " + nameSpaceQuota);
+ try {
+ long nameSpaceQuota = Long.parseLong(quotaInNamespace);
+ if (nameSpaceQuota <= 0) {
+ throw new IllegalArgumentException(
+ "Invalid value for namespace quota: " + nameSpaceQuota);
+ }
+ return new OzoneQuota(nameSpaceQuota, new RawQuotaInBytes(Units.B, -1));
+ } catch (NumberFormatException e) {
+ throw new IllegalArgumentException(quotaInNamespace + " is invalid. " +
+ "The quota value should be a positive integer between 1 and
Long.MAX_VALUE");
Review Comment:
The actual value of Long.MAX_VALUE is actually very large, it might not be
very acceptable for a regular user. We can maybe just make the error message as
"positive integer". For more details on limits the user can refer to
[documentation](https://github.com/apache/ozone/blob/ea9930591b4dd44b88d55241aecff22ef202b17c/hadoop-hdds/docs/content/feature/Quota.md?plain=1#L143)
where the proper definitions are mentioned.
If required we can specify the number limit in the documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
