LZD-PratyushBhatt commented on PR #5312:
URL: https://github.com/apache/ozone/pull/5312#issuecomment-1725809122
> Thanks @LZD-PratyushBhatt for the patch.
>
> I would like to suggest some refactoring for the Robot test:
>
> * extract assertions (the part that validates `${output_with_id_passed}`
and `${output_without_id_passed}`) into keywords (one for free-text output, one
for JSON), to avoid duplication
> * separate the two new test cases (so we should have 4 in total)
Thanks for the review @adoroszlai , made the changes. Please re-review,
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
