duongkame commented on code in PR #5302:
URL: https://github.com/apache/ozone/pull/5302#discussion_r1330788915
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/utils/db/CodecBuffer.java:
##########
@@ -153,8 +188,11 @@ private void assertRefCnt(int expected) {
Preconditions.assertSame(expected, buf.refCnt(), "refCnt");
}
- @Override
- protected void finalize() throws Throwable {
+ /**
+ * Provide an implementation of the {@link #finalize()} method.
+ * For performance reason, this class does not override {@link #finalize()}.
+ */
+ void finalizeImpl() {
Review Comment:
/nit can be named `detectLeaks`, no need to expose the details of finalize
here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
