ChenSammi commented on code in PR #4798:
URL: https://github.com/apache/ozone/pull/4798#discussion_r1331722864
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeConfiguration.java:
##########
@@ -137,7 +146,7 @@ public class DatanodeConfiguration {
* missed. With max threads 5, optimistically DN can handle 1500 individual
* container delete tx in 60s with RocksDB cache miss.
*/
- @Config(key = "block.delete.threads.max",
+ @Config(key = BLOCK_DELETE_THREAD_MAX,
Review Comment:
@xichen01 , I find this property is registered to ReconfigurationHandler,
but it doesn't have the "reconfigurable = true" field, while the property
"block.deleting.limit.per.interval" below has the "reconfigurable = true" but
not registered to ReconfigurationHandler.
Could you explain it a bit more that what's the required steps to make a
property reconfigurable, and whether "reconfigurable = true" is an mandatory
attribute for a reconfigurable property?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]