sodonnel commented on PR #5331: URL: https://github.com/apache/ozone/pull/5331#issuecomment-1727322347
Have you performed any benchmarks to prove wrapping the stream with a buffered stream makes things faster? It is my understanding that a write to a FileoutputStream is buffered in places as the data flows to the OS and onto the disk, so this wrapping is probably not needed. Also, 8MB seems like quite a large buffer? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
