ChenSammi commented on code in PR #4913:
URL: https://github.com/apache/ozone/pull/4913#discussion_r1331078837
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeConfiguration.java:
##########
@@ -188,6 +188,24 @@ public class DatanodeConfiguration {
private long recoveringContainerScrubInterval =
Duration.ofMinutes(10).toMillis();
+ /**
+ * Timeout for the thread used to process the delete block command
+ * to wait for the container lock.
+ * It takes about 200ms to open a RocksDB with HDD media.
+ * Set the default value to 100ms, so that after one times retry
+ * after waiting timeout, the hold time spent waiting for the lock
+ * is not greater than the time spent operating RocksDB
+ */
+ @Config(key = "block.delete.command.handle.lock.timeout",
Review Comment:
@xichen01 , is the slow RocksDB open a major cause behind this patch? I
have one question, it takes 200ms to open a rocksdb, you set this timeout to
100ms, and retry once in the block deletion logic, why not set the default
value to 200ms, with a simpler handler logic?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
