devmadhuu commented on PR #5311:
URL: https://github.com/apache/ozone/pull/5311#issuecomment-1728992892

   > > thanks for working on this @smitajoshi12!
   > > > @smitajoshi12 thanks for working on this patch, PR description says 
need to show leader information in ozone manager webUI, however I think we 
already show LEADER and FOLLOWER info in OM Web UI, but in JSON format, so pls 
correct the PR description and PR title.
   > > 
   > > 
   > > I agree with Devesh, the OM roles are already present in the OM UI, it 
was added by @ArafatKhan2198 in 
[HDDS-6863](https://issues.apache.org/jira/browse/HDDS-6863). For me it looks 
good already as it is, all the necessary information is present there. This new 
table that is nested in another table looks a bit weird for me, but maybe 
that's just for me :) If we want to have a change like this, maybe it should be 
moved to a new table, but I'm not sure if that would improve the OM UI that 
much. In the SCM UI it also presents this information in JSON format. Let me 
know what you think!
   > 
   > @dombizita Hi ZIta, Done Changes as suggested by you. Attached new 
Screenshot.
   
   @smitajoshi12 what is "`tanle`" format as you have mentioned in PR title. Is 
it by mistake ? Also PR description is not in line with what is being done in 
this patch. Also I agree with @dombizita , if this patch really needed as JSON 
format itself look fine and we want to keep any formatting or processing over 
OM UI as minimal as possible unless it is very much necessary. Can we keep same 
as in SCM webUI (in Json format) ? @dombizita @sumitagrawl pls suggest.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to