ivandika3 commented on PR #5341:
URL: https://github.com/apache/ozone/pull/5341#issuecomment-1730704716
Thanks for the patch.
I noticed there are some inconsistencies in the usage of bucket layout in
the request.
```java
OmKeyInfo omKeyInfo =
omMetadataManager.getKeyTable(bucketLayout).get(objectKey);
```
and
```java
omMetadataManager.getKeyTable(getBucketLayout()).addCacheEntry(
new CacheKey<>(
omMetadataManager.getOzoneKey(volumeName, bucketName,
keyName)),
CacheValue.get(trxnLogIndex));
```
The first one uses the `bucketLayout` from the method argument, the second
one uses `getBucketLayout`. Maybe we can remove the `validateAndUpdateCache`
with the `bucketLayout` argument, and uses `getBucketLayout` instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
