sodonnel commented on PR #5324:
URL: https://github.com/apache/ozone/pull/5324#issuecomment-1731877535

   > * EC containers will all have BCSID = 0. We may end up loading an old open 
EC container without all the data.
   
   Yea, EC is a problem. I was considering putting in something to avoid 
deleting the EC ones, and it also makes me wonder if EC needs to have an 
incrementing BCSID too. As things stand, without this change, a random 
container could get loaded on restart. I am not sure if there is anything we 
can use on EC containers to decide.
   
   Another issue with EC is that you may have replicaIndex=1 and replicaIndex, 
say 3 on the DN. We can only load and keep one of them - what to do then!?
   
   > I think that a CLOSED container should always win
   
   CLOSED should always have the highest BCSID, but perhaps there are some edge 
cases where it would not. But it does make sense to put unhealthy last if there 
is a tie.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to