aswinshakil commented on code in PR #5339:
URL: https://github.com/apache/ozone/pull/5339#discussion_r1339310982
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/DirectoryDeletingService.java:
##########
@@ -222,12 +225,122 @@ public BackgroundTaskResult call() {
getOzoneManager().getMetadataManager().getTableLock(
OmMetadataManagerImpl.DELETED_DIR_TABLE).writeLock().unlock();
}
+
+ try {
+ if (remainNum > 0) {
+ expandSnapshotDirectories(remainNum);
+ }
+ } catch (Exception e) {
Review Comment:
It will throw because we still do `get` from RocksDB. But the exception on
inside of `expandSnapshotDirectories` is specific for iterating through
`snapDeletedDirTable`. The one outside is overall exeption. The main reason is
`expandSnapshotDirectories` already las many `try` blocks, adding more will
decrease the readability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
