aswinshakil commented on code in PR #5361:
URL: https://github.com/apache/ozone/pull/5361#discussion_r1340761898
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java:
##########
@@ -1024,6 +1026,7 @@ void generateSnapshotDiffReport(final String jobKey,
throw new RuntimeException(exception);
} catch (Exception exception) {
updateJobStatusToFailed(jobKey, exception.getMessage());
+ ozoneManager.getMetrics().incNumSnapshotDiffJobFails();
Review Comment:
Do you want to move it inside `updateJobStatusToFailed` so that we can avoid
duplication?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
