duongkame commented on code in PR #5376:
URL: https://github.com/apache/ozone/pull/5376#discussion_r1341986291
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerStateMachine.java:
##########
@@ -267,8 +267,7 @@ public TransactionContext startTransaction(
@Override
public TransactionContext preAppendTransaction(TransactionContext trx)
throws IOException {
- OMRequest request = OMRatisHelper.convertByteStringToOMRequest(
- trx.getStateMachineLogEntry().getLogData());
+ final OMRequest request = (OMRequest) trx.getStateMachineContext();
OzoneManagerProtocolProtos.Type cmdType = request.getCmdType();
Review Comment:
All these validations should be on `startTransaction` as well. The creation
of UGI is quite expensive as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
