sodonnel commented on PR #5377:
URL: https://github.com/apache/ozone/pull/5377#issuecomment-1742810694
I think this change looks good, although there is one failing test which
might be related.
```
Error: Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
0.914 s <<< FAILURE! - in
org.apache.hadoop.hdds.scm.ha.TestStatefulServiceStateManagerImpl
Error:
org.apache.hadoop.hdds.scm.ha.TestStatefulServiceStateManagerImpl.testSaveConfiguration
Time elapsed: 0.888 s <<< ERROR!
org.apache.hadoop.hdds.scm.exceptions.SCMException:
org.apache.ratis.protocol.exceptions.StateMachineException:
java.lang.ClassCastException from Server peer@group-5A17DA7EDC91:
java.lang.AssertionError cannot be cast to java.lang.Exception
at
org.apache.hadoop.hdds.scm.ha.SCMHAInvocationHandler.translateException(SCMHAInvocationHandler.java:165)
at
org.apache.hadoop.hdds.scm.ha.SCMHAInvocationHandler.invokeRatis(SCMHAInvocationHandler.java:115)
at
org.apache.hadoop.hdds.scm.ha.SCMHAInvocationHandler.invoke(SCMHAInvocationHandler.java:74)
at com.sun.proxy.$Proxy16.saveConfiguration(Unknown Source)
at
org.apache.hadoop.hdds.scm.ha.TestStatefulServiceStateManagerImpl.testSaveConfiguration(TestStatefulServiceStateManagerImpl.java:81)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
```
I have kicked it off again to see how it does on a retry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]