xichen01 commented on code in PR #5358:
URL: https://github.com/apache/ozone/pull/5358#discussion_r1343932443
##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/DBScanner.java:
##########
@@ -114,9 +131,18 @@ public class DBScanner implements Callable<Void>,
SubcommandWithParent {
showDefaultValue = CommandLine.Help.Visibility.ALWAYS)
private boolean showCount;
- private String keySeparatorSchemaV3 =
+ @CommandLine.Option(names = {"--compact"},
+ description = "disable the pretty print the output",
+ defaultValue = "false")
+ private static boolean compact;
+
+ private static final String KEY_SEPARATOR_SCHEMA_V3 =
new OzoneConfiguration().getObject(DatanodeConfiguration.class)
.getContainerSchemaV3KeySeparator();
+ private static final int BATCH_SIZE = 10000;
+ private static final int THREAD_COUNT = 10;
Review Comment:
Yes, we can make these parameters configurable, but I didn't do this because
I found that after the `THREAD_COUNT`
(number of threads) is greater than 4, the parameters have less of an impact
on performance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
