hemantk-12 commented on PR #5262: URL: https://github.com/apache/ozone/pull/5262#issuecomment-1747342797
> I guess we can just disable snapshots all together in case of snapshot corruption. OzoneManager#isFilesystemSnapshotEnabled(). Since snapdiff & deep clean should also not run. 1. `OzoneManager#isFilesystemSnapshotEnabled()` is based on ozone config. I don't think it is a good idea to leverage it for snapshot chain corruption. We can add something else but it would be similar to `SnapshotChainManager#snapshotChainCorrupted`. 2. Any operation relying on `SnapshotChainManager` should fail and would fail. If I'm not wrong, snapDiff, snapshot read and snapshot list don't rely on `SnapshotChainManager`. So I think it is OK to let them go. Regarding deep clean (or create snapshot), depends on `SnapshotChainManager` because it is used to move keys around and cause snapshot corruption is wrong keys are moved. Deep clean will fail here: https://github.com/apache/ozone/blob/master/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/KeyDeletingService.java#L228 and similar for creation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
