guohao-rosicky commented on code in PR #5310: URL: https://github.com/apache/ozone/pull/5310#discussion_r1349455153
########## hadoop-hdds/tools/src/test/java/org/apache/hadoop/hdds/scm/cli/container/upgrade/TestUpgradeManager.java: ########## @@ -0,0 +1,312 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * <p> + * http://www.apache.org/licenses/LICENSE-2.0 + * <p> + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hdds.scm.cli.container.upgrade; + +import com.google.common.collect.Lists; +import org.apache.commons.io.FileUtils; +import org.apache.hadoop.hdds.client.BlockID; +import org.apache.hadoop.hdds.conf.OzoneConfiguration; +import org.apache.hadoop.hdds.protocol.DatanodeDetails; +import org.apache.hadoop.hdds.protocol.datanode.proto.ContainerProtos; +import org.apache.hadoop.hdds.utils.db.Table; +import org.apache.hadoop.ozone.OzoneConsts; +import org.apache.hadoop.ozone.common.Checksum; +import org.apache.hadoop.ozone.common.ChunkBuffer; +import org.apache.hadoop.ozone.container.ContainerTestHelper; +import org.apache.hadoop.ozone.container.common.helpers.BlockData; +import org.apache.hadoop.ozone.container.common.helpers.ChunkInfo; +import org.apache.hadoop.ozone.container.common.impl.ContainerLayoutVersion; +import org.apache.hadoop.ozone.container.common.impl.ContainerSet; +import org.apache.hadoop.ozone.container.common.statemachine.DatanodeConfiguration; +import org.apache.hadoop.ozone.container.common.transport.server.ratis.DispatcherContext; +import org.apache.hadoop.ozone.container.common.utils.StorageVolumeUtil; +import org.apache.hadoop.ozone.container.common.volume.HddsVolume; +import org.apache.hadoop.ozone.container.common.volume.MutableVolumeSet; +import org.apache.hadoop.ozone.container.common.volume.RoundRobinVolumeChoosingPolicy; +import org.apache.hadoop.ozone.container.common.volume.StorageVolume; +import org.apache.hadoop.ozone.container.keyvalue.KeyValueContainer; +import org.apache.hadoop.ozone.container.keyvalue.KeyValueContainerData; +import org.apache.hadoop.ozone.container.keyvalue.impl.BlockManagerImpl; +import org.apache.hadoop.ozone.container.keyvalue.impl.FilePerBlockStrategy; +import org.apache.hadoop.ozone.container.keyvalue.interfaces.BlockManager; +import org.apache.hadoop.ozone.container.metadata.DatanodeSchemaThreeDBDefinition; +import org.apache.hadoop.ozone.container.metadata.DatanodeStoreSchemaThreeImpl; +import org.apache.ozone.test.GenericTestUtils; +import org.junit.After; +import org.junit.Before; +import org.junit.Test; +import org.mockito.Mockito; + +import java.io.File; +import java.io.IOException; +import java.util.ArrayList; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.UUID; +import java.util.concurrent.atomic.AtomicInteger; + +import static org.apache.hadoop.hdds.HddsConfigKeys.OZONE_METADATA_DIRS; +import static org.apache.hadoop.hdds.scm.ScmConfigKeys.HDDS_DATANODE_DIR_KEY; +import static org.apache.hadoop.ozone.container.common.states.endpoint.VersionEndpointTask.LOG; +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertTrue; +import static org.mockito.ArgumentMatchers.anyList; +import static org.mockito.ArgumentMatchers.anyLong; +import static org.mockito.Mockito.mock; + +/** + * Tests for UpgradeSubCommand class. + */ +public class TestUpgradeManager { + + private File testRoot; + private String scmId = UUID.randomUUID().toString(); + private MutableVolumeSet volumeSet; + private UUID datanodeId; + private RoundRobinVolumeChoosingPolicy volumeChoosingPolicy; + private static final OzoneConfiguration CONF = new OzoneConfiguration(); + + private BlockManager blockManager; + private FilePerBlockStrategy chunkManager; + private ContainerSet containerSet; + + private static final DispatcherContext WRITE_STAGE = + new DispatcherContext.Builder() + .setStage(DispatcherContext.WriteChunkStage.WRITE_DATA).build(); + + private static final DispatcherContext COMMIT_STAGE = + new DispatcherContext.Builder() + .setStage(DispatcherContext.WriteChunkStage.COMMIT_DATA).build(); + + @Before + public void setup() throws Exception { + DatanodeConfiguration dc = CONF.getObject(DatanodeConfiguration.class); + dc.setContainerSchemaV3Enabled(true); + CONF.setFromObject(dc); + + testRoot = + GenericTestUtils.getTestDir(TestUpgradeManager.class.getSimpleName()); + if (testRoot.exists()) { + FileUtils.cleanDirectory(testRoot); + } + + final File volume1Path = new File(testRoot, "volume1"); + final File volume2Path = new File(testRoot, "volume2"); + + assertTrue(volume1Path.mkdirs()); + assertTrue(volume2Path.mkdirs()); + + final File metadataPath = new File(testRoot, "metadata"); + assertTrue(metadataPath.mkdirs()); + + CONF.set(HDDS_DATANODE_DIR_KEY, + volume1Path.getAbsolutePath() + "," + volume2Path.getAbsolutePath()); + CONF.set(OZONE_METADATA_DIRS, metadataPath.getAbsolutePath()); + datanodeId = UUID.randomUUID(); + volumeSet = new MutableVolumeSet(datanodeId.toString(), scmId, CONF, + null, StorageVolume.VolumeType.DATA_VOLUME, null); + + // create rocksdb instance in volume dir + final List<HddsVolume> volumes = new ArrayList<>(); + for (StorageVolume storageVolume : volumeSet.getVolumesList()) { + HddsVolume hddsVolume = (HddsVolume) storageVolume; + StorageVolumeUtil.checkVolume(hddsVolume, scmId, scmId, CONF, null, null); + volumes.add(hddsVolume); + } + + DatanodeDetails datanodeDetails = Mockito.mock(DatanodeDetails.class); + Mockito.when(datanodeDetails.getUuidString()) + .thenReturn(datanodeId.toString()); + Mockito.when(datanodeDetails.getUuid()).thenReturn(datanodeId); + + volumeChoosingPolicy = mock(RoundRobinVolumeChoosingPolicy.class); + final AtomicInteger loopCount = new AtomicInteger(0); + Mockito.when(volumeChoosingPolicy.chooseVolume(anyList(), anyLong())) + .thenAnswer(invocation -> { + final int ii = loopCount.getAndIncrement() % volumes.size(); + return volumes.get(ii); + }); + + containerSet = new ContainerSet(1000); + + blockManager = new BlockManagerImpl(CONF); + chunkManager = new FilePerBlockStrategy(true, blockManager, null); + } + + @After + public void after() throws IOException { + FileUtils.deleteDirectory(testRoot); + } + + @Test + public void testUpgrade() throws IOException { + int num = 2; + + final Map<KeyValueContainerData, Map<String, BlockData>> + keyValueContainerBlockDataMap = genSchemaV2Containers(num); + assertEquals(num, keyValueContainerBlockDataMap.size()); + + shutdownAllVolume(); + + final UpgradeManager upgradeManager = new UpgradeManager(); + upgradeManager.initVolumeStoreMap(volumeSet, CONF); + final List<UpgradeManager.Result> results = + upgradeManager.upgradeAll(volumeSet, CONF); + + checkV3MetaData(keyValueContainerBlockDataMap, results, upgradeManager); + } + + private Map<String, BlockData> putAnyBlockData(KeyValueContainerData data, + KeyValueContainer container, + int numBlocks) { + // v3 key ==> block data + final Map<String, BlockData> containerBlockDataMap = new HashMap<>(); + + int txnID = 0; + for (int i = 0; i < numBlocks; i++) { + txnID = txnID + 1; + BlockID blockID = + ContainerTestHelper.getTestBlockID(data.getContainerID()); + BlockData kd = new BlockData(blockID); + List<ContainerProtos.ChunkInfo> chunks = Lists.newArrayList(); + putChunksInBlock(1, i, chunks, container, blockID); + kd.setChunks(chunks); + + try { + final String localIDKey = Long.toString(blockID.getLocalID()); + final String blockKey = DatanodeSchemaThreeDBDefinition + .getContainerKeyPrefix(data.getContainerID()) + localIDKey; Review Comment: > You can try `final String blockKey = data.getBlockKey(blockID.getLocalID()); ` The ContainerData object Schema represented by data is v2, so I'll generate the key directly using the v3 approach -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
