adoroszlai opened a new pull request, #5401:
URL: https://github.com/apache/ozone/pull/5401
## What changes were proposed in this pull request?
HDDS-9232 added a new test case in `TestOzoneManagerHAKeyDeletion`, now the
only other test case started failing.
```
org.apache.hadoop.ozone.om.TestOzoneManagerHAKeyDeletion.testKeyDeletion
Time elapsed: 5.575 s <<< ERROR!
java.lang.NullPointerException
at
org.apache.hadoop.ozone.om.TestOzoneManagerHAKeyDeletion.lambda$testKeyDeletion$0(TestOzoneManagerHAKeyDeletion.java:84)
at
org.apache.ozone.test.GenericTestUtils.waitFor(GenericTestUtils.java:221)
at
org.apache.hadoop.ozone.om.TestOzoneManagerHAKeyDeletion.testKeyDeletion(TestOzoneManagerHAKeyDeletion.java:83)
```
The root cause is that `TestOzoneManagerHA` restarts OMs after each test,
but `restart()` does not start `KeyManager`. The latter creates
`KeyDeletingService` only upon start.
Also fix `TestOmSnapshot`, which stops `KeyManager` after cluster startup.
Since it restarts OM in a few test cases, we need to stop `KeyManager` at those
points. This was not required previously due to the bug above.
https://issues.apache.org/jira/browse/HDDS-9412
## How was this patch tested?
Verified `TestOzoneManagerHAKeyDeletion` passes:
```
[INFO] Running org.apache.hadoop.ozone.om.TestOzoneManagerHAKeyDeletion
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
48.612 s - in org.apache.hadoop.ozone.om.TestOzoneManagerHAKeyDeletion
[INFO] org.apache.hadoop.ozone.om.TestOzoneManagerHAKeyDeletion.testConf
Time elapsed: 3.352 s
[INFO]
org.apache.hadoop.ozone.om.TestOzoneManagerHAKeyDeletion.testKeyDeletion Time
elapsed: 23.016 s
```
CI:
https://github.com/adoroszlai/hadoop-ozone/actions/runs/6442224627
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
