xichen01 commented on code in PR #4988:
URL: https://github.com/apache/ozone/pull/4988#discussion_r1349663858
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/block/DeletedBlockLogImpl.java:
##########
@@ -437,15 +350,26 @@ public DatanodeDeletedBlockTransactions getTransactions(
throws IOException {
lock.lock();
try {
+ // Here we can clean up the Datanode timeout command that no longer
+ // reports heartbeats
+ getSCMDeletedBlockTransactionStatusManager().cleanAllTimeoutSCMCommand(
Review Comment:
- "SCMBlockDeletingService timeout": is `SCMBlockDeletingService` itself
timeout, When the `SCMBlockDeletingService` thread is stuck, it may trigger the
- `scmCommandTimeoutMs`: is the `scmCommand` is the maximum time allowed
without an update, is used to prevent a commands from being lost in the process
of sending them to the DN, we can resend them after a timeout.
`scmCommand` can be update by DN Heartbeat, If no DN reports the status of a
`scmCommand` for 300s, then the `scmCommand` will be cleaned up due to a
timeout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
