devmadhuu commented on code in PR #5397:
URL: https://github.com/apache/ozone/pull/5397#discussion_r1350032752
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/scm/TestStorageContainerManager.java:
##########
@@ -344,7 +346,7 @@ public void testBlockDeletionTransactions() throws
Exception {
} catch (IOException e) {
Review Comment:
> I think this config may be used for HA case only even config name contains
"HA flush", It is used for non-HA case also?
Yes ideally non HA case, SCM should write deleted block transactions
directly to DB, so based on further analysis, we have this method
`org.apache.hadoop.hdds.scm.block.DeletedBlockLogStateManagerImpl#addTransactionsToDB`
which adds deleted blocks transactions to DB , and here we are adding to
transaction buffer , not directly to DB.
@sumitagrawl do you have an understanding of expected behavior ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
