adoroszlai commented on code in PR #5429:
URL: https://github.com/apache/ozone/pull/5429#discussion_r1359263150
##########
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/common/ContainerTestUtils.java:
##########
@@ -113,17 +113,23 @@ public static EndpointStateMachine
createEndpoint(Configuration conf,
new LegacyHadoopConfigurationSource(conf));
}
- public static OzoneContainer getOzoneContainer(
+ public static OzoneContainer getOzoneContainerWithMockContext(
Review Comment:
I suggest keeping the original name?
* reduce change
* there is no `getOzoneContainer` (without mock context) method we need to
differentiate from
##########
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/common/ContainerTestUtils.java:
##########
@@ -113,17 +113,23 @@ public static EndpointStateMachine
createEndpoint(Configuration conf,
new LegacyHadoopConfigurationSource(conf));
}
- public static OzoneContainer getOzoneContainer(
+ public static OzoneContainer getOzoneContainerWithMockContext(
Review Comment:
I suggest keeping the original name:
* reduce change
* there is no `getOzoneContainer` (without mock context) method we need to
differentiate from
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
