tanvipenumudy commented on code in PR #5421:
URL: https://github.com/apache/ozone/pull/5421#discussion_r1360271903
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerRatisServer.java:
##########
@@ -246,11 +250,16 @@ public OMResponse submitRequest(OMRequest omRequest)
throws ServiceException {
// In prepare mode, only prepare and cancel requests are allowed to go
// through.
if (ozoneManager.getPrepareState().requestAllowed(omRequest.getCmdType()))
{
- RaftClientRequest raftClientRequest =
- createWriteRaftClientRequest(omRequest);
- RaftClientReply raftClientReply =
submitRequestToRatis(raftClientRequest);
-
- return processReply(omRequest, raftClientReply);
+ RaftClientRequest raftClientRequest = captureLatencyNs(
+ perfMetrics.getConvertRatisRequestLatencyNs(),
+ () -> createWriteRaftClientRequest(omRequest));
Review Comment:
> Let's use the same name? i.e. when the method name is
createWriteRaftClientRequest, the metric name should be
getCreateWriteRaftClientRequestLatencyNs().
I agree with maintaining consistency by using the same name for methods and
metrics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
