adoroszlai commented on PR #5335: URL: https://github.com/apache/ozone/pull/5335#issuecomment-1764076653
> it still feels like a very expensive way to get the containers on a pipeline for a given owner. The new code will be forming a set of all containers for an owner across the whole cluster, and using that to filter the owners for a single pipeline. I was wondering the same. But "containers by owner" map already exists: https://github.com/apache/ozone/blob/f5d9223f99f1f4fbc76ba3c979dbceafd5fd83b6/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/states/ContainerStateMap.java#L88 we're just making an immutable copy of the set stored as the value in the map: https://github.com/apache/ozone/blob/f5d9223f99f1f4fbc76ba3c979dbceafd5fd83b6/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/states/ContainerAttribute.java#L192-L193 Would it be better keep the original iteration and use `hasContainerID` instead? https://github.com/apache/ozone/blob/f5d9223f99f1f4fbc76ba3c979dbceafd5fd83b6/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/states/ContainerAttribute.java#L113-L126 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
