fapifta commented on code in PR #5415:
URL: https://github.com/apache/ozone/pull/5415#discussion_r1361295229
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/security/x509/certificate/client/DefaultCertificateClient.java:
##########
@@ -584,7 +584,9 @@ public CertificateSignRequest.Builder getCSRBuilder()
CertificateSignRequest.Builder builder =
new CertificateSignRequest.Builder()
.setConfiguration(securityConfig)
- .addInetAddresses();
+ .addInetAddresses()
+ .setDigitalEncryption(true)
Review Comment:
We should remove these from the SCM and DN certificate client as well, once
we move these two call to set digital encryption and digital signature key
usage setting into DefaultCertificateClient.
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/security/x509/certificate/client/CommonCertificateClient.java:
##########
Review Comment:
As I see, this class is not used anymore, can we just delete it? Or do I
miss a usage here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
