adoroszlai commented on code in PR #5275:
URL: https://github.com/apache/ozone/pull/5275#discussion_r1361757980
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java:
##########
@@ -3622,6 +3637,17 @@ public List<OzoneFileStatus> listStatus(OmKeyArgs args,
boolean recursive,
}
}
+ public List<OzoneFileStatusLight> listStatusLight(OmKeyArgs args,
Review Comment:
```suggestion
@Override
public List<OzoneFileStatusLight> listStatusLight(OmKeyArgs args,
```
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/protocol/OzoneManagerProtocol.java:
##########
@@ -894,6 +895,20 @@ default OpenKeySession createFile(OmKeyArgs keyArgs,
boolean overWrite,
List<OzoneFileStatus> listStatus(OmKeyArgs keyArgs, boolean recursive,
String startKey, long numEntries) throws IOException;
+ /**
+ * Lightweight listStatus API.
+ *
+ * @param keyArgs Key args
+ * @param recursive For a directory if true all the descendants of a
+ * particular directory are listed
+ * @param startKey Key from which listing needs to start. If startKey
exists
+ * its status is included in the final list.
+ * @param numEntries Number of entries to list from the start key
+ * @return list of file status
+ */
+ List<OzoneFileStatusLight> listStatusLight(OmKeyArgs keyArgs,
+ boolean recursive, String startKey, long numEntries) throws IOException;
Review Comment:
`listStatus` methods evolved over time by introducing more and more
parameters, and the old methods were kept for backward compatibility. Since
`listStatusLight` is a new part of the API, I guess we don't need multiple
versions. I'd consider removing this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
