adoroszlai commented on code in PR #5456:
URL: https://github.com/apache/ozone/pull/5456#discussion_r1363724567
##########
hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/spi/impl/TestOzoneManagerServiceProviderImpl.java:
##########
@@ -147,6 +151,14 @@ public void testUpdateReconOmDBWithNewSnapshot() throws
Exception {
.get("/sampleVol/bucketOne/key_two"));
}
+ private static SCMNodeDetails getReconNodeDetails() {
+ SCMNodeDetails.Builder builder = new SCMNodeDetails.Builder();
+ builder.setSCMNodeId("Recon");
+ builder.setDatanodeProtocolServerAddress(
+ InetSocketAddress.createUnresolved("127.0.0.1", 9888));
+ return builder.build();
+ }
Review Comment:
It would be nice to extract this to a public test helper class (e.g.
`CommonUtils`?) and reuse in other unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
